From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17026 invoked by alias); 21 Mar 2011 20:06:39 -0000 Received: (qmail 16993 invoked by uid 22791); 21 Mar 2011 20:06:38 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Mar 2011 20:06:29 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2LK6Sae024328 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 21 Mar 2011 16:06:28 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2LK6RSl000522; Mon, 21 Mar 2011 16:06:27 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p2LK6QvV022608; Mon, 21 Mar 2011 16:06:26 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 0A467378491; Mon, 21 Mar 2011 14:06:25 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch 1/7] Support a ring of related breakpoints References: <20110319211505.GB30867@host1.jankratochvil.net> Date: Mon, 21 Mar 2011 20:11:00 -0000 In-Reply-To: <20110319211505.GB30867@host1.jankratochvil.net> (Jan Kratochvil's message of "Sat, 19 Mar 2011 22:15:06 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00970.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> currently breakpoint->related_breakpoint is used only to connect Jan> two related breakpoints. During STT_GNU_IFUNC one thread can be in Jan> the resolver while another thread also enters the resolver. But Jan> both threads will have a different return address where GDB wants Jan> to fetch the resolved address. Therefore one needs to track Jan> arbitrary number of the return address breakpoints while still Jan> catching new entries to the STT_GNU_IFUNC resolver. I read this and it looks fine to me. At first I didn't see how a ring was actually created, but the only set of this field is in watch_command_1, and it links the two together: b->related_breakpoint = scope_breakpoint; scope_breakpoint->related_breakpoint = b; Tom