Re: revert+new [patch]: Re: [patch] DWARF-3+ DW_AT_accessibility defaults #2 (GCC PR debug/45124)

[Tom Tromey <tromey@redhat.com>]

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> The problem is gcc-4.5.x has wrong DWARF output (GCC PR
Jan> debug/45124) and it does not provide any DW_AT_producer.  Therefore
Jan> proposing GDB would assume gcc-4.5.x when it sees no
Jan> DW_AT_producer.  Hopefully GCC is the only DWARF-4 DW_TAG_type_unit
Jan> producer out there (is it?) and finally hopefully it is the only
Jan> DW_TAG_type_unit producer forgetting to output DW_AT_producer.  It
Jan> would be probably worth to wait on the resolution of GCC PR
Jan> debug/48229 before assuming its implications.

I think this patch seems reasonable.

To be clear, this comment is documented what we hope will be true,
right?

+	  /* Workaround GCC PR debug/48229 where DW_TAG_type_unit had no
+	     DW_AT_producer in G++ 4.5.x.  G++ 4.4.any could not produce
+	     DWARF-4 (and its DW_TAG_type_unit).  G++ 4.6.0 already provides
+	     DW_AT_producer for DW_TAG_type_unit.  */

... since the bug is still open and, I guess, 4.6 snapshots don't emit
this.

Tom