From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8394 invoked by alias); 22 Mar 2011 18:10:50 -0000 Received: (qmail 8360 invoked by uid 22791); 22 Mar 2011 18:10:47 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Mar 2011 18:10:39 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2MIAbPn029972 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 22 Mar 2011 14:10:37 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2MIAavQ013816; Tue, 22 Mar 2011 14:10:36 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p2MIAZWK021836; Tue, 22 Mar 2011 14:10:36 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 78BA5378491; Tue, 22 Mar 2011 12:10:35 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: revert+new [patch]: Re: [patch] DWARF-3+ DW_AT_accessibility defaults #2 (GCC PR debug/45124) References: <20110321154428.GA3761@host1.jankratochvil.net> <20110322095904.GA29625@host1.jankratochvil.net> Date: Tue, 22 Mar 2011 18:16:00 -0000 In-Reply-To: <20110322095904.GA29625@host1.jankratochvil.net> (Jan Kratochvil's message of "Tue, 22 Mar 2011 10:59:04 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg01001.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> The problem is gcc-4.5.x has wrong DWARF output (GCC PR Jan> debug/45124) and it does not provide any DW_AT_producer. Therefore Jan> proposing GDB would assume gcc-4.5.x when it sees no Jan> DW_AT_producer. Hopefully GCC is the only DWARF-4 DW_TAG_type_unit Jan> producer out there (is it?) and finally hopefully it is the only Jan> DW_TAG_type_unit producer forgetting to output DW_AT_producer. It Jan> would be probably worth to wait on the resolution of GCC PR Jan> debug/48229 before assuming its implications. I think this patch seems reasonable. To be clear, this comment is documented what we hope will be true, right? + /* Workaround GCC PR debug/48229 where DW_TAG_type_unit had no + DW_AT_producer in G++ 4.5.x. G++ 4.4.any could not produce + DWARF-4 (and its DW_TAG_type_unit). G++ 4.6.0 already provides + DW_AT_producer for DW_TAG_type_unit. */ ... since the bug is still open and, I guess, 4.6 snapshots don't emit this. Tom