From: Tom Tromey <tromey@redhat.com>
To: Kevin Pouget <kevin.pouget@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [RFC - Python] New ObjFile event
Date: Wed, 05 Oct 2011 14:16:00 -0000 [thread overview]
Message-ID: <m38vozle1f.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CAPftXULAgW_X22mqam+W6DUca-K-1VXtyxinwSLdwDfgcHi2tA@mail.gmail.com> (Kevin Pouget's message of "Wed, 5 Oct 2011 13:10:18 +0200")
>>>>> "Kevin" == Kevin Pouget <kevin.pouget@gmail.com> writes:
Tom> I think it is best to pass it as part of the event.
Tom> It is ok with me if you also want to have it set the current objfile.
Kevin> I got rid of the "gdb.current_objfile ()" access to the objfile and
Kevin> kept only the "NewObjFile.new_objfile" attribute of the Event object,
Kevin> which indeed makes more sense.
Kevin> I've updated the code and documentation accordingly; could you please
Kevin> tell me if it seems good for you?
It needs another doc review.
One nit on the code:
Kevin> (gdbpy_current_objfile): New global variable.
Kevin> * python/python.c (gdbpy_current_objfile): Make global.
Now that you aren't setting this in the event generator, there is no
need for these hunks.
The code bits are ok with that changed.
Tom
next prev parent reply other threads:[~2011-10-05 14:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AANLkTimybJtpUzy13FuLxQQMJfeWQuf3-cgqGmu23Bq5@mail.gmail.com>
2011-03-28 8:49 ` Kevin Pouget
2011-03-28 8:51 ` Kevin Pouget
2011-03-28 9:00 ` Phil Muldoon
2011-03-28 8:54 ` Phil Muldoon
2011-03-28 9:03 ` Phil Muldoon
2011-03-28 10:02 ` Kevin Pouget
2011-03-28 20:28 ` Tom Tromey
2011-03-29 11:11 ` Kevin Pouget
2011-03-30 11:32 ` Kevin Pouget
2011-03-30 12:14 ` Phil Muldoon
2011-03-30 12:15 ` Kevin Pouget
2011-05-19 20:21 ` Tom Tromey
2011-05-23 8:44 ` Kevin Pouget
2011-09-01 9:56 ` Kevin Pouget
2011-09-01 11:01 ` Eli Zaretskii
2011-09-01 11:09 ` Kevin Pouget
2011-10-03 16:32 ` Tom Tromey
[not found] ` <CAPftXULEe9R4m7tF=vtJe6NTXHSFAkXgsHCPb3r0mU4wKx0FFg@mail.gmail.com>
2011-10-04 8:25 ` Kevin Pouget
2011-10-04 17:02 ` Tom Tromey
2011-10-05 11:10 ` Kevin Pouget
2011-10-05 14:16 ` Tom Tromey [this message]
2011-10-05 17:40 ` Eli Zaretskii
2011-10-07 7:40 ` Kevin Pouget
2011-10-07 7:54 ` Kevin Pouget
2011-10-07 8:37 Andreas Tobler
2011-10-07 8:44 ` Kevin Pouget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38vozle1f.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=kevin.pouget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox