From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84135-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 24262 invoked by alias); 5 Oct 2011 14:16:32 -0000
Received: (qmail 24254 invoked by uid 22791); 5 Oct 2011 14:16:31 -0000
X-SWARE-Spam-Status: No, hits=-7.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_BJ
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Oct 2011 14:16:17 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p95EGEjw005735	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 5 Oct 2011 10:16:14 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p95EGEFI017329;	Wed, 5 Oct 2011 10:16:14 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p95EGCAF002968;	Wed, 5 Oct 2011 10:16:13 -0400
From: Tom Tromey <tromey@redhat.com>
To: Kevin Pouget <kevin.pouget@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [RFC - Python] New ObjFile event
References: <AANLkTimybJtpUzy13FuLxQQMJfeWQuf3-cgqGmu23Bq5@mail.gmail.com>	<AANLkTin=YO__Mz88HPFoT7a6_it5BxthnUdODJMs52eG@mail.gmail.com>	<m362r3q9ih.fsf@fleche.redhat.com>	<AANLkTikmMVf7Lz=8ccdXeo1WG8k+ivHMCXkC7BkZkLNP@mail.gmail.com>	<AANLkTi=ObZFW+uoecfzvHhXr55zYZzSgX2ocJJrvXDv0@mail.gmail.com>	<m339m4dgzr.fsf@redhat.com>	<AANLkTima2Kk8C16hjj0kTtvsH9W33CbiE2y6wrVQXns5@mail.gmail.com>	<m3ipt68mrs.fsf@fleche.redhat.com>	<BANLkTi=NqJK6c+Cbvhc1M2fE=cS=5khSJg@mail.gmail.com>	<CAPftXUKyge-BpB05PTn=5C=1HG6hgv8eS9rDYiZhooVMrrgZuQ@mail.gmail.com>	<E1Qz4Lp-0007E1-Kl@fencepost.gnu.org>	<CAPftXULTp2Z9PsY_RM+MAwahcEjNk2s=kgqUhz1guCMYUXGN9g@mail.gmail.com>	<m3botyujd4.fsf@fleche.redhat.com>	<CAPftXULEe9R4m7tF=vtJe6NTXHSFAkXgsHCPb3r0mU4wKx0FFg@mail.gmail.com>	<m3vcs4oflt.fsf@fleche.redhat.com>	<CAPftXULAgW_X22mqam+W6DUca-K-1VXtyxinwSLdwDfgcHi2tA@mail.gmail.com>
Date: Wed, 05 Oct 2011 14:16:00 -0000
In-Reply-To: <CAPftXULAgW_X22mqam+W6DUca-K-1VXtyxinwSLdwDfgcHi2tA@mail.gmail.com>	(Kevin Pouget's message of "Wed, 5 Oct 2011 13:10:18 +0200")
Message-ID: <m38vozle1f.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-10/txt/msg00138.txt.bz2

>>>>> "Kevin" == Kevin Pouget <kevin.pouget@gmail.com> writes:

Tom> I think it is best to pass it as part of the event.
Tom> It is ok with me if you also want to have it set the current objfile.

Kevin> I got rid of the "gdb.current_objfile ()" access to the objfile and
Kevin> kept only the "NewObjFile.new_objfile" attribute of the Event object,
Kevin> which indeed makes more sense.
Kevin> I've updated the code and documentation accordingly; could you please
Kevin> tell me if it seems good for you?

It needs another doc review.

One nit on the code:

Kevin> 	(gdbpy_current_objfile): New global variable.
Kevin> 	* python/python.c (gdbpy_current_objfile): Make global.

Now that you aren't setting this in the event generator, there is no
need for these hunks.

The code bits are ok with that changed.

Tom