From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Doug Evans <xdje42@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] PR python/16699: GDB Python command completion with overriden complete vs. completer class
Date: Tue, 08 Jul 2014 20:30:00 -0000 [thread overview]
Message-ID: <m38uo3zj8r.fsf@redhat.com> (raw)
In-Reply-To: <20140708153221.GA15767@host2.jankratochvil.net> (Jan Kratochvil's message of "Tue, 8 Jul 2014 17:32:21 +0200")
On Tuesday, July 08 2014, Jan Kratochvil wrote:
> Hi Sergio,
>
> the testcase FAILs with "read1" from:
> reproducer for races of expect incomplete reads
> http://sourceware.org/bugzilla/show_bug.cgi?id=12649
>
> Additionally the testcase uses $objdir instead of [standard_output_file],
> filed for it now tracking PR:
> $objdir and $subdir should be tainted
> https://sourceware.org/bugzilla/show_bug.cgi?id=17129
On Tuesday, July 08 2014, Jan Kratochvil wrote:
> On Tue, 08 Jul 2014 17:32:21 +0200, Jan Kratochvil wrote:
>> - -re "^completefilecommandcond ${objdir}/${subdir}/py-completion-t$" {
>> + -re "^completefilecommandcond ${completion_regex}$" {
>
> There was a racy bug here - and even in the former test - here should be:
> + -re "^completefilecommandcond ${completion_regex}\007$" {
>
> Updated fix attached.
Hello Jan,
Thank you for the catches. I will update my local version.
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2014-07-08 20:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 22:49 Sergio Durigan Junior
2014-03-22 2:54 ` Sergio Durigan Junior
2014-04-04 20:41 ` Sergio Durigan Junior
2014-04-10 16:27 ` Tom Tromey
2014-05-03 0:04 ` Sergio Durigan Junior
2014-05-20 19:12 ` Tom Tromey
2014-05-21 2:09 ` Sergio Durigan Junior
2014-05-21 7:48 ` Doug Evans
2014-07-01 0:59 ` Sergio Durigan Junior
2014-07-08 15:32 ` Jan Kratochvil
2014-07-08 18:17 ` Jan Kratochvil
2014-07-08 20:30 ` Sergio Durigan Junior [this message]
2014-08-19 23:02 ` Sergio Durigan Junior
2014-09-02 16:31 ` Sergio Durigan Junior
2014-09-03 4:03 ` Doug Evans
2014-09-03 20:36 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38uo3zj8r.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox