From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-114051-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19401 invoked by alias); 8 Jul 2014 20:30:24 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 19355 invoked by uid 89); 8 Jul 2014 20:30:20 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 08 Jul 2014 20:30:19 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s68KUGNS028743	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);	Tue, 8 Jul 2014 16:30:16 -0400
Received: from psique (ovpn-113-28.phx2.redhat.com [10.3.113.28])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s68KUDdq027222	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Tue, 8 Jul 2014 16:30:15 -0400
From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Doug Evans <xdje42@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] PR python/16699: GDB Python command completion with overriden complete vs. completer class
References: <m3iorj3ud8.fsf@redhat.com> <87a9btqhe3.fsf@fleche.redhat.com>	<m361ln20e8.fsf@redhat.com> <87y4xwqn71.fsf@fleche.redhat.com>	<m3ha4jevbq.fsf@redhat.com> <m3mweb6096.fsf@sspiff.org>	<m3fviluc6a.fsf@redhat.com>	<20140708153221.GA15767@host2.jankratochvil.net>
X-URL: http://www.redhat.com
Date: Tue, 08 Jul 2014 20:30:00 -0000
In-Reply-To: <20140708153221.GA15767@host2.jankratochvil.net> (Jan	Kratochvil's message of "Tue, 8 Jul 2014 17:32:21 +0200")
Message-ID: <m38uo3zj8r.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-IsSubscribed: yes
X-SW-Source: 2014-07/txt/msg00156.txt.bz2

On Tuesday, July 08 2014, Jan Kratochvil wrote:

> Hi Sergio,
>
> the testcase FAILs with "read1" from:
> 	reproducer for races of expect incomplete reads
> 	http://sourceware.org/bugzilla/show_bug.cgi?id=12649
>
> Additionally the testcase uses $objdir instead of [standard_output_file],
> filed for it now tracking PR:
> 	$objdir and $subdir should be tainted
> 	https://sourceware.org/bugzilla/show_bug.cgi?id=17129

On Tuesday, July 08 2014, Jan Kratochvil wrote:

> On Tue, 08 Jul 2014 17:32:21 +0200, Jan Kratochvil wrote:
>> -    -re "^completefilecommandcond ${objdir}/${subdir}/py-completion-t$" {
>> +    -re "^completefilecommandcond ${completion_regex}$" {
>
> There was a racy bug here - and even in the former test - here should be:
>   +    -re "^completefilecommandcond ${completion_regex}\007$" {
>
> Updated fix attached.

Hello Jan,

Thank you for the catches.  I will update my local version.

-- 
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/