From: Tom Tromey <tromey@redhat.com>
To: Keith Seitz <keiths@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Token cleanup in c-exp.y
Date: Tue, 25 Aug 2009 18:41:00 -0000 [thread overview]
Message-ID: <m37hwrvkbe.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4A94248B.20701@redhat.com> (Keith Seitz's message of "Tue, 25 Aug 2009 10:51:07 -0700")
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Tom> The last field should be 1 here, and then the tokentab2 and tokentab3
Tom> logic in yylex needs the same cxx_only treatment as ident_tokens.
Keith> Yes, indeed. I've fixed that
Thanks.
Tom> I suppose that the "::" operator also needs to be C++-only.
Keith> I don't think we can do that. "::" is also used by gdb for
Keith> non-language constructs like filename::function and
Keith> function::variable. There are several scattered tests on this already.
Thanks for looking into this and adding the comment.
Keith> New patch attached.
This is ok.
Tom
next prev parent reply other threads:[~2009-08-25 18:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-24 23:06 Keith Seitz
2009-08-24 23:08 ` Tom Tromey
2009-08-25 5:03 ` Keith Seitz
2009-08-25 13:45 ` Pierre Muller
2009-08-25 14:10 ` Jiang Jilin
2009-08-25 15:11 ` Andreas Schwab
2009-08-25 15:28 ` Matt Rice
2009-08-25 15:46 ` Tom Tromey
2009-08-25 15:47 ` Tom Tromey
2009-08-25 18:07 ` Keith Seitz
2009-08-25 18:41 ` Tom Tromey [this message]
2009-08-25 18:42 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37hwrvkbe.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox