From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21594 invoked by alias); 25 Aug 2009 18:07:46 -0000 Received: (qmail 21582 invoked by uid 22791); 25 Aug 2009 18:07:46 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Aug 2009 18:07:39 +0000 Received: from int-mx07.intmail.prod.int.phx2.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7PI7bAt004556 for ; Tue, 25 Aug 2009 14:07:37 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx07.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n7PI7a4P009333; Tue, 25 Aug 2009 14:07:37 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n7PI7ZQh027456; Tue, 25 Aug 2009 14:07:36 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 24A473784A9; Tue, 25 Aug 2009 12:07:34 -0600 (MDT) From: Tom Tromey To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Token cleanup in c-exp.y References: <4A9313C2.3050907@redhat.com> <4A94248B.20701@redhat.com> Reply-To: Tom Tromey Date: Tue, 25 Aug 2009 18:41:00 -0000 In-Reply-To: <4A94248B.20701@redhat.com> (Keith Seitz's message of "Tue, 25 Aug 2009 10:51:07 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00424.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Tom> The last field should be 1 here, and then the tokentab2 and tokentab3 Tom> logic in yylex needs the same cxx_only treatment as ident_tokens. Keith> Yes, indeed. I've fixed that Thanks. Tom> I suppose that the "::" operator also needs to be C++-only. Keith> I don't think we can do that. "::" is also used by gdb for Keith> non-language constructs like filename::function and Keith> function::variable. There are several scattered tests on this already. Thanks for looking into this and adding the comment. Keith> New patch attached. This is ok. Tom