From: Tom Tromey <tromey@redhat.com>
To: pfee@talk21.com
Cc: gdb-patches@sourceware.org
Subject: Re: Enhancement - show old and new thread info when switching during debugging
Date: Sat, 30 Jul 2011 11:32:00 -0000 [thread overview]
Message-ID: <m37h703jn9.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1311947955.89527.YahooMailRC@web86708.mail.ird.yahoo.com> (pfee@talk21.com's message of "Fri, 29 Jul 2011 14:59:15 +0100 (BST)")
>>>>> "Paul" == pfee <pfee@talk21.com> writes:
A few style nits in the patch...
Paul> + const char* previous_pid_str = strdup (target_pid_to_str
Space before the "*", not after.
Paul> + free ((void*)previous_pid_str);
Use xfree, not free.
You don't need the cast.
Tom
next prev parent reply other threads:[~2011-07-29 20:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-29 15:29 pfee
2011-07-29 16:01 ` Joel Brobecker
2011-07-29 16:33 ` pfee
2011-07-29 17:38 ` Joel Brobecker
2011-07-29 17:47 ` pfee
2011-07-29 20:40 ` Philippe Waroquiers
2011-07-30 2:44 ` Tom Tromey
2011-07-30 11:39 ` Joel Brobecker
2011-07-30 11:44 ` Pedro Alves
2011-07-30 14:12 ` pfee
2011-08-08 11:35 ` pfee
2011-08-08 15:07 ` Pedro Alves
2011-08-08 15:20 ` pfee
2011-08-09 15:25 ` pfee
2011-08-10 15:10 ` Pedro Alves
2011-08-16 16:01 ` pfee
2011-07-30 12:40 ` pfee
2011-07-30 11:32 ` Tom Tromey [this message]
2011-07-30 22:07 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37h703jn9.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pfee@talk21.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox