From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82724-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18870 invoked by alias); 29 Jul 2011 20:40:57 -0000
Received: (qmail 18861 invoked by uid 22791); 29 Jul 2011 20:40:57 -0000
X-SWARE-Spam-Status: No, hits=-7.5 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 29 Jul 2011 20:40:44 +0000
Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6TKehFb012132	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 29 Jul 2011 16:40:43 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p6TKehoY015876;	Fri, 29 Jul 2011 16:40:43 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6TKegdE004901;	Fri, 29 Jul 2011 16:40:42 -0400
From: Tom Tromey <tromey@redhat.com>
To: pfee@talk21.com
Cc: gdb-patches@sourceware.org
Subject: Re: Enhancement - show old and new thread info when switching during debugging
References: <1311947955.89527.YahooMailRC@web86708.mail.ird.yahoo.com>
Date: Sat, 30 Jul 2011 11:32:00 -0000
In-Reply-To: <1311947955.89527.YahooMailRC@web86708.mail.ird.yahoo.com>	(pfee@talk21.com's message of "Fri, 29 Jul 2011 14:59:15 +0100 (BST)")
Message-ID: <m37h703jn9.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00819.txt.bz2

>>>>> "Paul" == pfee  <pfee@talk21.com> writes:

A few style nits in the patch...

Paul> +      const char* previous_pid_str = strdup (target_pid_to_str 

Space before the "*", not after.

Paul> +      free ((void*)previous_pid_str);

Use xfree, not free.
You don't need the cast.

Tom