From: Tom Tromey <tromey@redhat.com>
To: Justin Lebar <justin.lebar@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, Stan Shebs <stan_shebs@mentor.com>,
gdb-patches@sourceware.org
Subject: Re: Status of 'blacklist' patch?
Date: Fri, 28 Oct 2011 19:53:00 -0000 [thread overview]
Message-ID: <m37h3o99rn.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CAFWcpZ6o+VHW5qMU+ZWZNw3a6_f_cFTf+EHZwHpKrBnERGQWxg@mail.gmail.com> (Justin Lebar's message of "Fri, 28 Oct 2011 15:46:01 -0400")
>>>>> "Justin" == Justin Lebar <justin.lebar@gmail.com> writes:
Justin> I'm sorry about all the formatting issues; it's hard to keep multiple
Justin> styles in my head at once! I need a set of git hooks to pester me, I
Justin> guess.
No worries, everybody struggles with this.
I wish we could define our style as the output of some tool; then we
wouldn't have to review for this at all. But AFAIK no tool comes close
enough.
>> Blank line between intro comment and the start of the function.
>> I think there are a few instances of this.
Justin> Only for function definitions, not declarations, right? I don't see
Justin> blank lines in breakpoint.h, for example.
I think so. Or at least I don't recall us agreeing on anything and the
code is already not very consistent.
Unfortunately I just noticed a different issue, so you'll need one more
spin. See my other mail.
Tom
next prev parent reply other threads:[~2011-10-28 19:49 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 12:12 Diego Novillo
2011-10-06 14:08 ` Justin Lebar
2011-10-06 15:51 ` Stan Shebs
2011-10-06 20:16 ` Justin Lebar
2011-10-10 12:34 ` Stan Shebs
2011-10-11 21:34 ` Justin Lebar
2011-10-11 23:54 ` Doug Evans
2011-10-16 19:22 ` Justin Lebar
2011-10-20 19:46 ` Tom Tromey
2011-10-25 20:07 ` Justin Lebar
2011-10-25 20:41 ` Pedro Alves
2011-10-25 21:25 ` Justin Lebar
2011-10-20 20:40 ` Eli Zaretskii
2011-10-25 16:47 ` Justin Lebar
2011-10-25 16:53 ` Eli Zaretskii
2011-10-25 19:52 ` Justin Lebar
2011-10-25 20:13 ` Eli Zaretskii
2011-10-25 20:30 ` Justin Lebar
2011-10-26 1:06 ` Stan Shebs
2011-10-26 3:45 ` Justin Lebar
2011-10-26 5:37 ` Stan Shebs
2011-10-26 8:10 ` Joel Brobecker
2011-10-26 13:28 ` Eli Zaretskii
2011-10-26 15:11 ` Justin Lebar
2011-10-28 18:18 ` Tom Tromey
2011-10-28 19:48 ` Justin Lebar
2011-10-28 19:53 ` Tom Tromey [this message]
2011-10-28 19:49 ` Tom Tromey
2011-10-28 19:55 ` Justin Lebar
2011-10-28 20:37 ` Tom Tromey
2011-10-31 15:52 ` Justin Lebar
[not found] ` <4EAF2E0E.7080508@earthlink.net>
2011-11-01 14:53 ` Justin Lebar
2011-11-02 22:43 ` Maciej W. Rozycki
2011-11-02 23:52 ` Stan Shebs
2011-11-03 0:20 ` Maciej W. Rozycki
2011-11-03 3:54 ` Eli Zaretskii
2011-11-03 14:32 ` Tom Tromey
2011-11-03 16:54 ` Eli Zaretskii
2011-11-03 18:04 ` Maciej W. Rozycki
2011-11-03 18:25 ` Eli Zaretskii
2011-11-03 19:01 ` Stan Shebs
2011-10-06 17:19 ` Diego Novillo
2011-10-06 17:33 ` Tom Tromey
2011-10-06 17:37 ` Diego Novillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37h3o99rn.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=justin.lebar@gmail.com \
--cc=stan_shebs@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox