From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15145 invoked by alias); 28 Oct 2011 19:49:55 -0000 Received: (qmail 15134 invoked by uid 22791); 28 Oct 2011 19:49:54 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SINGLE_HEADER_1K,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 28 Oct 2011 19:49:39 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9SJnYHT006225 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 28 Oct 2011 15:49:34 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p9SJnYKD028320; Fri, 28 Oct 2011 15:49:34 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p9SJnWbt027906; Fri, 28 Oct 2011 15:49:32 -0400 From: Tom Tromey To: Justin Lebar Cc: Eli Zaretskii , Stan Shebs , gdb-patches@sourceware.org Subject: Re: Status of 'blacklist' patch? References: <4E8DCE67.80507@earthlink.net> <4E92E639.7000402@earthlink.net> <83ipnjs9i1.fsf@gnu.org> <83ipndc92n.fsf@gnu.org> <83ehy0ded8.fsf@gnu.org> <4EA753C4.60408@mentor.com> Date: Fri, 28 Oct 2011 19:53:00 -0000 In-Reply-To: (Justin Lebar's message of "Fri, 28 Oct 2011 15:46:01 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00779.txt.bz2 >>>>> "Justin" == Justin Lebar writes: Justin> I'm sorry about all the formatting issues; it's hard to keep multiple Justin> styles in my head at once! I need a set of git hooks to pester me, I Justin> guess. No worries, everybody struggles with this. I wish we could define our style as the output of some tool; then we wouldn't have to review for this at all. But AFAIK no tool comes close enough. >> Blank line between intro comment and the start of the function. >> I think there are a few instances of this. Justin> Only for function definitions, not declarations, right? I don't see Justin> blank lines in breakpoint.h, for example. I think so. Or at least I don't recall us agreeing on anything and the code is already not very consistent. Unfortunately I just noticed a different issue, so you'll need one more spin. See my other mail. Tom