From: Sergio Durigan Junior <sergiodj@redhat.com>
To: jose.marchesi@oracle.com (Jose E. Marchesi)
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] add gdbarch_in_function_epilogue_p hook for sparc64
Date: Wed, 16 Oct 2013 20:53:00 -0000 [thread overview]
Message-ID: <m37gddhr8l.fsf@redhat.com> (raw)
In-Reply-To: <87mwm9b8pr.fsf@oracle.com> (Jose E. Marchesi's message of "Wed, 16 Oct 2013 16:18:08 +0200")
On Wednesday, October 16 2013, Jose E. Marchesi wrote:
> Hi.
>
[...]
> 2013-10-16 Jose E. Marchesi <jose.marchesi@oracle.com>
>
> * sparc-tdep.c (sparc_in_function_epilogue_p): New function.
> (X_RETTURN): New macro.
> * sparc-tdep.h: sparc_in_function_epilogue_p prototype.
>
> * sparc64-tdep.c (sparc64_init_abi): Hook
> sparc_in_function_epilogue_p.
>
>
[...]
> Index: sparc-tdep.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/sparc-tdep.h,v
> retrieving revision 1.33
> diff -u -r1.33 sparc-tdep.h
> --- sparc-tdep.h 1 Jan 2013 06:32:51 -0000 1.33
> +++ sparc-tdep.h 16 Oct 2013 14:00:49 -0000
> @@ -193,6 +193,9 @@
> extern struct sparc_frame_cache *
> sparc32_frame_cache (struct frame_info *this_frame, void **this_cache);
>
> +extern int
> +sparc_in_function_epilogue_p (struct gdbarch *gdbarch, CORE_ADDR pc);
Not really a review, but the function name should not start on column 0
for prototypes.
Thanks,
--
Sergio
next prev parent reply other threads:[~2013-10-16 20:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-16 14:16 Jose E. Marchesi
2013-10-16 20:53 ` Sergio Durigan Junior [this message]
2013-10-17 11:33 ` Jose E. Marchesi
2013-12-03 11:58 ` Jose E. Marchesi
2013-12-03 19:03 ` Pedro Alves
2013-12-04 10:07 ` Jose E. Marchesi
2013-12-04 12:15 ` Pedro Alves
2013-12-04 12:22 ` Jose E. Marchesi
2014-01-29 15:31 ` Jose E. Marchesi
2014-02-06 14:24 ` Jose E. Marchesi
2014-02-08 3:01 ` Joel Brobecker
2014-02-10 12:37 ` Jose E. Marchesi
2014-02-10 15:08 ` Mark Kettenis
2014-02-10 15:23 ` Jose E. Marchesi
2013-12-04 17:02 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37gddhr8l.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jose.marchesi@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox