From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31380 invoked by alias); 16 Oct 2013 20:53:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31363 invoked by uid 89); 16 Oct 2013 20:53:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Oct 2013 20:53:52 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9GKrowY014043 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 16 Oct 2013 16:53:50 -0400 Received: from psique (ovpn-113-80.phx2.redhat.com [10.3.113.80]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9GKrlV0006118 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 16 Oct 2013 16:53:49 -0400 From: Sergio Durigan Junior To: jose.marchesi@oracle.com (Jose E. Marchesi) Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] add gdbarch_in_function_epilogue_p hook for sparc64 References: <87mwm9b8pr.fsf@oracle.com> X-URL: http://www.redhat.com Date: Wed, 16 Oct 2013 20:53:00 -0000 In-Reply-To: <87mwm9b8pr.fsf@oracle.com> (Jose E. Marchesi's message of "Wed, 16 Oct 2013 16:18:08 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2013-10/txt/msg00501.txt.bz2 On Wednesday, October 16 2013, Jose E. Marchesi wrote: > Hi. > [...] > 2013-10-16 Jose E. Marchesi > > * sparc-tdep.c (sparc_in_function_epilogue_p): New function. > (X_RETTURN): New macro. > * sparc-tdep.h: sparc_in_function_epilogue_p prototype. > > * sparc64-tdep.c (sparc64_init_abi): Hook > sparc_in_function_epilogue_p. > > [...] > Index: sparc-tdep.h > =================================================================== > RCS file: /cvs/src/src/gdb/sparc-tdep.h,v > retrieving revision 1.33 > diff -u -r1.33 sparc-tdep.h > --- sparc-tdep.h 1 Jan 2013 06:32:51 -0000 1.33 > +++ sparc-tdep.h 16 Oct 2013 14:00:49 -0000 > @@ -193,6 +193,9 @@ > extern struct sparc_frame_cache * > sparc32_frame_cache (struct frame_info *this_frame, void **this_cache); > > +extern int > +sparc_in_function_epilogue_p (struct gdbarch *gdbarch, CORE_ADDR pc); Not really a review, but the function name should not start on column 0 for prototypes. Thanks, -- Sergio