From: Andreas Arnez <arnez@linux.vnet.ibm.com>
To: Pedro Alves <palves@redhat.com>
Cc: Ulrich Weigand <uweigand@de.ibm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/6] S390: Watchpoint enhancements and hardware breakpoints
Date: Fri, 16 Sep 2016 17:30:00 -0000 [thread overview]
Message-ID: <m37fablpoe.fsf@oc1027705133.ibm.com> (raw)
In-Reply-To: <c0d0de65-429d-7449-7f98-f8aefb1058e7@redhat.com> (Pedro Alves's message of "Fri, 16 Sep 2016 16:43:48 +0100")
On Fri, Sep 16 2016, Pedro Alves wrote:
> I see. Thanks for the clarification.
>
> A comment to the effect in the code would be nice. Maybe it's
> there and I missed it.
OK, changed the relevant comment to this:
/* Don't install hardware breakpoints while single-stepping, since
our PER settings (e.g. the nullification bit) might then conflict
with the kernel's. But re-install them afterwards. */
Also changed the documentation of lwp_is_stepping as suggested by Yao:
/* Return nonzero if we are single-stepping this LWP at the ptrace
level. */
> I have no further comments on the series. LGTM.
Thanks. Pushed with the changes above.
--
Andreas
next prev parent reply other threads:[~2016-09-16 17:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 11:53 Andreas Arnez
2016-09-15 11:54 ` [PATCH] Fix order of inferiors in "thread apply all" Andreas Arnez
2016-09-15 12:03 ` Andreas Arnez
2016-09-15 11:59 ` [PATCH 1/6] S390: Avoid direct access to lwp_info structure Andreas Arnez
2016-09-15 12:01 ` [PATCH 3/6] S390: Multi-inferior watchpoint support Andreas Arnez
2016-09-15 12:02 ` [PATCH 6/6] S390: Hardware breakpoint support Andreas Arnez
2016-09-15 12:02 ` [PATCH 2/6] S390: Migrate watch areas from list to VEC type Andreas Arnez
2016-09-15 12:02 ` [PATCH 4/6] S390: Enable "maint set show-debug-regs" Andreas Arnez
2016-09-15 12:02 ` [PATCH 5/6] linux-nat: Add function lwp_is_stepping Andreas Arnez
2016-09-15 15:08 ` Yao Qi
2016-09-15 14:11 ` [PATCH 0/6] S390: Watchpoint enhancements and hardware breakpoints Pedro Alves
2016-09-16 12:43 ` Ulrich Weigand
2016-09-16 15:43 ` Pedro Alves
2016-09-16 17:30 ` Andreas Arnez [this message]
2016-09-15 14:58 ` Yao Qi
2016-09-15 17:14 ` Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37fablpoe.fsf@oc1027705133.ibm.com \
--to=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox