Re: RFA: automatic dependency tracking

[Tom Tromey <tromey@redhat.com>]

>>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:

Thiago> Only one issue though. Any reason why python.o and python-utils.o were
Thiago> left with the header dependencies?

Just an oversight.

Here is a patch.  I tested it using GNU make (all I've got) but it
just applies the obvious transformation and should be safe in general.
I also moved the python bits up above the dependency-tracking bits,
for consistency.

Ok?

Tom

b/gdb/ChangeLog:
2008-08-08  Tom Tromey  <tromey@redhat.com>

	* Makefile.in (python.o): Remove dependencies.  Use COMPILE and
	POSTCOMPILE.
	(python-utils.o): Likewise.

diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index 0a61c24..7f8c9ea 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1822,6 +1822,23 @@ tui-winsource.o: $(srcdir)/tui/tui-winsource.c
 	$(COMPILE) $(srcdir)/tui/tui-winsource.c
 	$(POSTCOMPILE)
 
+#
+# gdb/python/ dependencies
+#
+# Need to explicitly specify the compile rule as make will do nothing
+# or try to compile the object file into the sub-directory.
+
+# Flags needed to compile Python code
+PYTHON_CFLAGS=@PYTHON_CFLAGS@
+
+python.o: $(srcdir)/python/python.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python.c
+	$(POSTCOMPILE)
+
+python-utils.o: $(srcdir)/python/python-utils.c
+	$(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-utils.c
+	$(POSTCOMPILE)
+
 \f
 
 #
@@ -1863,22 +1880,4 @@ $(all_object_files) : $(generated_files)
 # Dependencies.
 @GMAKE_TRUE@-include $(patsubst %.o, $(DEPDIR)/%.Po, $(all_object_files))
 
-#
-# gdb/python/ dependencies
-#
-# Need to explicitly specify the compile rule as make will do nothing
-# or try to compile the object file into the sub-directory.
-
-# Flags needed to compile Python code
-PYTHON_CFLAGS=@PYTHON_CFLAGS@
-
-python.o: $(srcdir)/python/python.c $(defs_h) $(python_h) \
-	$(command_h) $(libiberty_h) $(cli_decode_h) $(charset_h) $(top_h) \
-	$(exceptions_h) $(python_internal_h) $(version_h) $(cli_script_h) \
-	$(ui_out_h) $(target_h) $(gdbthread_h)
-	$(CC) -c $(INTERNAL_CFLAGS) $(PYTHON_CFLAGS) $(srcdir)/python/python.c
-python-utils.o: $(srcdir)/python/python-utils.c $(defs_h) $(python_internal_h)
-	$(CC) -c $(INTERNAL_CFLAGS) $(PYTHON_CFLAGS) \
-	  $(srcdir)/python/python-utils.c -o python-utils.o
-
 ### end of the gdb Makefile.in.