From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10844 invoked by alias); 8 Aug 2008 15:18:28 -0000 Received: (qmail 10834 invoked by uid 22791); 8 Aug 2008 15:18:27 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 08 Aug 2008 15:17:24 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m78FHM8D032557 for ; Fri, 8 Aug 2008 11:17:22 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m78FHLpP014749; Fri, 8 Aug 2008 11:17:21 -0400 Received: from opsy.redhat.com (vpn-10-89.bos.redhat.com [10.16.10.89]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m78FHLYd013580; Fri, 8 Aug 2008 11:17:21 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id B46E8508577; Fri, 8 Aug 2008 09:17:22 -0600 (MDT) To: Thiago Jung Bauermann Cc: Ralf Wildenhues , gdb-patches@sources.redhat.com Subject: Re: RFA: automatic dependency tracking References: <20080807054840.GA26651@ins.uni-bonn.de> <20080807191516.GG27560@ins.uni-bonn.de> <20080807205842.GA4628@caradoc.them.org> <20080807225006.GA25330@ins.uni-bonn.de> <1218206154.8002.6.camel@localhost.localdomain> From: Tom Tromey Reply-To: Tom Tromey X-Attribution: Tom Date: Fri, 08 Aug 2008 15:18:00 -0000 In-Reply-To: <1218206154.8002.6.camel@localhost.localdomain> (Thiago Jung Bauermann's message of "Fri\, 08 Aug 2008 11\:35\:54 -0300") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00200.txt.bz2 >>>>> "Thiago" == Thiago Jung Bauermann writes: Thiago> Only one issue though. Any reason why python.o and python-utils.o were Thiago> left with the header dependencies? Just an oversight. Here is a patch. I tested it using GNU make (all I've got) but it just applies the obvious transformation and should be safe in general. I also moved the python bits up above the dependency-tracking bits, for consistency. Ok? Tom b/gdb/ChangeLog: 2008-08-08 Tom Tromey * Makefile.in (python.o): Remove dependencies. Use COMPILE and POSTCOMPILE. (python-utils.o): Likewise. diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 0a61c24..7f8c9ea 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -1822,6 +1822,23 @@ tui-winsource.o: $(srcdir)/tui/tui-winsource.c $(COMPILE) $(srcdir)/tui/tui-winsource.c $(POSTCOMPILE) +# +# gdb/python/ dependencies +# +# Need to explicitly specify the compile rule as make will do nothing +# or try to compile the object file into the sub-directory. + +# Flags needed to compile Python code +PYTHON_CFLAGS=@PYTHON_CFLAGS@ + +python.o: $(srcdir)/python/python.c + $(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python.c + $(POSTCOMPILE) + +python-utils.o: $(srcdir)/python/python-utils.c + $(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/python-utils.c + $(POSTCOMPILE) + # @@ -1863,22 +1880,4 @@ $(all_object_files) : $(generated_files) # Dependencies. @GMAKE_TRUE@-include $(patsubst %.o, $(DEPDIR)/%.Po, $(all_object_files)) -# -# gdb/python/ dependencies -# -# Need to explicitly specify the compile rule as make will do nothing -# or try to compile the object file into the sub-directory. - -# Flags needed to compile Python code -PYTHON_CFLAGS=@PYTHON_CFLAGS@ - -python.o: $(srcdir)/python/python.c $(defs_h) $(python_h) \ - $(command_h) $(libiberty_h) $(cli_decode_h) $(charset_h) $(top_h) \ - $(exceptions_h) $(python_internal_h) $(version_h) $(cli_script_h) \ - $(ui_out_h) $(target_h) $(gdbthread_h) - $(CC) -c $(INTERNAL_CFLAGS) $(PYTHON_CFLAGS) $(srcdir)/python/python.c -python-utils.o: $(srcdir)/python/python-utils.c $(defs_h) $(python_internal_h) - $(CC) -c $(INTERNAL_CFLAGS) $(PYTHON_CFLAGS) \ - $(srcdir)/python/python-utils.c -o python-utils.o - ### end of the gdb Makefile.in.