From: Tom Tromey <tromey@redhat.com>
To: Ken Werner <ken@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Printing of character vectors
Date: Fri, 25 Jun 2010 21:59:00 -0000 [thread overview]
Message-ID: <m363164vv7.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201006251037.29862.ken@linux.vnet.ibm.com> (Ken Werner's message of "Fri, 25 Jun 2010 10:37:29 +0200")
>>>>> "Ken" == Ken Werner <ken@linux.vnet.ibm.com> writes:
Ken> I noticed that char vectors are printed like char arrays (as
Ken> strings). Here is the output of a sample session:
Ken> Is this intended?
I do not know. The test case was written that way, but that isn't
necessarily indicative of intent.
Is it ever useful?
Ken> The attached patch changes c_val_print to additionally check if the
Ken> type is a vector. Tested on powerpc64-*-linux-gnu and
Ken> i686-*-linux-gnu, no regressions. Any suggestions are welcome.
The patch itself is fine. I think the only question is what behavior we
want.
If you don't hear any objections in the next week, go ahead and check it
in.
Tom
next prev parent reply other threads:[~2010-06-25 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-25 8:37 Ken Werner
2010-06-25 21:59 ` Tom Tromey [this message]
2010-06-27 17:15 ` Joel Brobecker
2010-07-02 14:06 ` Ken Werner
2010-07-02 18:03 ` Tom Tromey
2010-07-05 8:18 ` Ken Werner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m363164vv7.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ken@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox