From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7466 invoked by alias); 25 Jun 2010 21:59:16 -0000 Received: (qmail 7457 invoked by uid 22791); 25 Jun 2010 21:59:15 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Jun 2010 21:59:11 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5PLx9WP007511 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 25 Jun 2010 17:59:10 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5PLx9xC023815; Fri, 25 Jun 2010 17:59:09 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o5PLx8R3005967; Fri, 25 Jun 2010 17:59:08 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 49F333792DB; Fri, 25 Jun 2010 15:59:08 -0600 (MDT) From: Tom Tromey To: Ken Werner Cc: gdb-patches@sourceware.org Subject: Re: [patch] Printing of character vectors References: <201006251037.29862.ken@linux.vnet.ibm.com> Reply-To: tromey@redhat.com Date: Fri, 25 Jun 2010 21:59:00 -0000 In-Reply-To: <201006251037.29862.ken@linux.vnet.ibm.com> (Ken Werner's message of "Fri, 25 Jun 2010 10:37:29 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00605.txt.bz2 >>>>> "Ken" == Ken Werner writes: Ken> I noticed that char vectors are printed like char arrays (as Ken> strings). Here is the output of a sample session: Ken> Is this intended? I do not know. The test case was written that way, but that isn't necessarily indicative of intent. Is it ever useful? Ken> The attached patch changes c_val_print to additionally check if the Ken> type is a vector. Tested on powerpc64-*-linux-gnu and Ken> i686-*-linux-gnu, no regressions. Any suggestions are welcome. The patch itself is fine. I think the only question is what behavior we want. If you don't hear any objections in the next week, go ahead and check it in. Tom