From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Ian Lance Taylor <iant@google.com>, Doug Evans <dje@google.com>,
gdb-patches@sourceware.org
Subject: Re: [patch] Support -fsplit-stack (previous frame inner to this frame)
Date: Wed, 24 Nov 2010 18:34:00 -0000 [thread overview]
Message-ID: <m362vmzi31.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20101124002923.GA6482@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Wed, 24 Nov 2010 01:29:23 +0100")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> That optimization makes no sense there:
Jan> * This check is done only in the error case.
Jan> (For frame_find_by_id it does not seem to be needed.)
Good point.
Jan> * Any lookup caching should be done rather in the symbols lookup
Jan> code anyway.
Yeah.
Jan> * frame.c (get_prev_frame_1) <UNWIND_INNER_ID>: New variables
Jan> this_pc_in_block, morestack_msym and morestack_name. Check for
Jan> "__morestack" minimal symbol there.
It looks good to me.
Tom
next prev parent reply other threads:[~2010-11-24 18:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 0:13 Jan Kratochvil
2010-11-23 0:34 ` Doug Evans
2010-11-23 2:12 ` Jan Kratochvil
2010-11-23 20:41 ` Tom Tromey
2010-11-23 22:38 ` Ian Lance Taylor
2010-11-24 0:29 ` Jan Kratochvil
2010-11-24 18:34 ` Tom Tromey [this message]
2011-01-03 13:11 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m362vmzi31.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=iant@google.com \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox