From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12709 invoked by alias); 24 Nov 2010 18:34:37 -0000 Received: (qmail 12698 invoked by uid 22791); 24 Nov 2010 18:34:36 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Nov 2010 18:34:31 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAOIYSNa020307 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 24 Nov 2010 13:34:28 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oAOIYR23030952; Wed, 24 Nov 2010 13:34:28 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id oAOIYR5k027804; Wed, 24 Nov 2010 13:34:27 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 1D566C884CC; Wed, 24 Nov 2010 11:34:27 -0700 (MST) From: Tom Tromey To: Jan Kratochvil Cc: Ian Lance Taylor , Doug Evans , gdb-patches@sourceware.org Subject: Re: [patch] Support -fsplit-stack (previous frame inner to this frame) References: <20101124002923.GA6482@host0.dyn.jankratochvil.net> Date: Wed, 24 Nov 2010 18:34:00 -0000 In-Reply-To: <20101124002923.GA6482@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Wed, 24 Nov 2010 01:29:23 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00399.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> That optimization makes no sense there: Jan> * This check is done only in the error case. Jan> (For frame_find_by_id it does not seem to be needed.) Good point. Jan> * Any lookup caching should be done rather in the symbols lookup Jan> code anyway. Yeah. Jan> * frame.c (get_prev_frame_1) : New variables Jan> this_pc_in_block, morestack_msym and morestack_name. Check for Jan> "__morestack" minimal symbol there. It looks good to me. Tom