Make "j" an alias of "jump" [was: Re: "j" is now an ambiguous command]

Make "j" an alias of "jump" [was: Re: "j" is now an ambiguous command]

[Sergio Durigan Junior]

On Saturday, September 15 2012, Jan Engelhardt wrote:

> Between gdb-7.3 and 7.4.50.20120603, gdb has gained the two commands 
> "jit-reader-load" and "jit-reader-unload".
> This causes "j", previously used as a shortcut for "jump", to have 
> become ambiguous. I would ask for "j" to be recognized again, similar to 
> how "b" is synonymous with "break" despite the presence of other b* 
> commands.
>
>   (gdb) j 1762
> Ambiguous command "j 1762": jit-reader-load, jit-reader-unload, jump.

Thanks for the report.  I agree that "jump" is a command more used than
the "jit*" commands.

The following patch fixes the issue.

Ok to apply?

-- 
Sergio

gdb/ChangeLog:
2012-09-18  Sergio Durigan Junior  <sergiodj@redhat.com>

	* infcmd.c (_initialize_infcmd): Register `j' as an alias for
	`jump'.

gdb/doc/ChangeLog:
2012-09-18  Sergio Durigan Junior  <sergiodj@redhat.com>

	* gdb.texinfo (jump): Mention new alias `j' for `jump'.

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index cd4513b..ddcbbad 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -15495,8 +15495,11 @@ an address of your own choosing, with the following commands:
 
 @table @code
 @kindex jump
+@kindex j @r{(@code{jump})}
 @item jump @var{linespec}
+@itemx j @var{linespec}
 @itemx jump @var{location}
+@itemx j @var{location}
 Resume execution at line @var{linespec} or at address given by
 @var{location}.  Execution stops again immediately if there is a
 breakpoint there.  @xref{Specify Location}, for a description of the
diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index cce624e..fd035df 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -3104,6 +3104,7 @@ Usage: jump <location>\n\
 Give as argument either LINENUM or *ADDR, where ADDR is an expression\n\
 for an address to start at."));
   set_cmd_completer (c, location_completer);
+  add_com_alias ("j", "jump", class_run, 1);
 
   if (xdb_commands)
     {

Re: Make "j" an alias of "jump" [was: Re: "j" is now an ambiguous command]

[Tom Tromey]

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> 2012-09-18  Sergio Durigan Junior  <sergiodj@redhat.com>
Sergio> 	* infcmd.c (_initialize_infcmd): Register `j' as an alias for
Sergio> 	`jump'.

The code bits are ok.

Thanks for picking this up.

Tom

Re: Make "j" an alias of "jump" [was: Re: "j" is now an ambiguous command]

[Eli Zaretskii]

> From: Sergio Durigan Junior <sergiodj@redhat.com>
> Cc: gdb-patches@sourceware.org
> Date: Tue, 18 Sep 2012 16:43:46 -0300
> 
> >   (gdb) j 1762
> > Ambiguous command "j 1762": jit-reader-load, jit-reader-unload, jump.
> 
> Thanks for the report.  I agree that "jump" is a command more used than
> the "jit*" commands.
> 
> The following patch fixes the issue.
> 
> Ok to apply?

The documentation part is OK, thanks.

Re: Make "j" an alias of "jump" [was: Re: "j" is now an ambiguous command]

[Sergio Durigan Junior]

On Tuesday, September 18 2012, Tom Tromey wrote:

>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> 2012-09-18  Sergio Durigan Junior  <sergiodj@redhat.com>
> Sergio> 	* infcmd.c (_initialize_infcmd): Register `j' as an alias for
> Sergio> 	`jump'.
>
> The code bits are ok.
>
> Thanks for picking this up.

Thanks Tom and Eli.

Checked in:

        http://sourceware.org/ml/gdb-cvs/2012-09/msg00100.html

-- 
Sergio