From: Jim Blandy <jimb@codesourcery.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: Delete broken and unused HPUXHPPA code
Date: Wed, 29 Aug 2007 22:08:00 -0000 [thread overview]
Message-ID: <m34piiat9w.fsf@codesourcery.com> (raw)
In-Reply-To: <200708291835.l7TIZ2Th015104@brahms.sibelius.xs4all.nl> (Mark Kettenis's message of "Wed, 29 Aug 2007 20:35:02 +0200 (CEST)")
Mark Kettenis <mark.kettenis@xs4all.nl> writes:
>> From: Jim Blandy <jimb@codesourcery.com>
>> Date: Wed, 29 Aug 2007 11:06:04 -0700
>>
>> The #ifdef block this patch deletes contains unbalanced parenthesis;
>> it wouldn't compile. The mistake was introduced by this change:
>>
>> 2005-02-10 Andrew Cagney <cagney@gnu.org>
>>
>> Mark up all error and warning messages.
>>
>> Since nobody has noticed it, it's clear that nobody has compiled this
>> code with HPUXHPPA defined for two and a half years. The block of
>> code itself dates from GDB's prehistory. This is the only "HPUXHPPA"
>> block in all of GDB.
>>
>> Can we delete the code?
>>
>> gdb/ChangeLog:
>> 2007-08-29 Jim Blandy <jimb@codesourcery.com>
>>
>> * breakpoint.c (watch_command_1): Remove '#ifdef HPUXHPPA' block;
>> this code has not been compiled for two years.
>
> Go for it.
Committed, thanks. :)
prev parent reply other threads:[~2007-08-29 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-29 18:06 Jim Blandy
2007-08-29 18:27 ` Joel Brobecker
2007-08-29 18:28 ` Daniel Jacobowitz
2007-08-29 18:37 ` Mark Kettenis
2007-08-29 22:08 ` Jim Blandy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34piiat9w.fsf@codesourcery.com \
--to=jimb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox