From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-50560-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5024 invoked by alias); 29 Aug 2007 22:08:18 -0000
Received: (qmail 5015 invoked by uid 22791); 29 Aug 2007 22:08:17 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 29 Aug 2007 22:08:13 +0000
Received: (qmail 27145 invoked from network); 29 Aug 2007 22:08:11 -0000
Received: from unknown (HELO localhost) (jimb@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 29 Aug 2007 22:08:11 -0000
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: Delete broken and unused HPUXHPPA code
References: <m3veayi5bn.fsf@codesourcery.com> 	<200708291835.l7TIZ2Th015104@brahms.sibelius.xs4all.nl>
From: Jim Blandy <jimb@codesourcery.com>
Date: Wed, 29 Aug 2007 22:08:00 -0000
In-Reply-To: <200708291835.l7TIZ2Th015104@brahms.sibelius.xs4all.nl> (Mark Kettenis's message of "Wed, 29 Aug 2007 20:35:02 +0200 (CEST)")
Message-ID: <m34piiat9w.fsf@codesourcery.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-08/txt/msg00533.txt.bz2


Mark Kettenis <mark.kettenis@xs4all.nl> writes:
>> From: Jim Blandy <jimb@codesourcery.com>
>> Date: Wed, 29 Aug 2007 11:06:04 -0700
>> 
>> The #ifdef block this patch deletes contains unbalanced parenthesis;
>> it wouldn't compile.  The mistake was introduced by this change:
>> 
>>     2005-02-10  Andrew Cagney  <cagney@gnu.org>
>> 
>>             Mark up all error and warning messages.
>> 
>> Since nobody has noticed it, it's clear that nobody has compiled this
>> code with HPUXHPPA defined for two and a half years.  The block of
>> code itself dates from GDB's prehistory.  This is the only "HPUXHPPA"
>> block in all of GDB.
>> 
>> Can we delete the code?
>> 
>> gdb/ChangeLog:
>> 2007-08-29  Jim Blandy  <jimb@codesourcery.com>
>> 
>> 	* breakpoint.c (watch_command_1): Remove '#ifdef HPUXHPPA' block;
>> 	this code has not been compiled for two years.
>
> Go for it.

Committed, thanks. :)