From: Jim Blandy <jimb@codesourcery.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Make DWARF-2 "address size" explicit
Date: Mon, 17 Dec 2007 20:06:00 -0000 [thread overview]
Message-ID: <m34pehje1b.fsf@codesourcery.com> (raw)
In-Reply-To: <20071216215917.GI2618@caradoc.them.org> (Daniel Jacobowitz's message of "Sun, 16 Dec 2007 16:59:17 -0500")
Daniel Jacobowitz <drow at false.org> writes:
> On Sun, Dec 09, 2007 at 08:39:55PM +0100, Ulrich Weigand wrote:
>> This patch changes this by making the parameter explicit as member
>> of the dwarf_expr_context structure. The core DWARF expresssion
>> engine thus no longer needs to make this assumption.
>
> Seems right to me!
This is certainly a step in the right direction. However, the proper
value to use for addr_size is the one that comes from the header of
the compilation unit containing the expression. (The fact that
there's no compilation unit associated with the frame information is
an existing problem.)
I had a patch to carry that through from a long while back. A fellow
from Intel has been working on updating it; I've encouraged him to
post it here.
http://sourceware.org/ml/gdb-patches/2006-05/msg00226.html
next prev parent reply other threads:[~2007-12-17 19:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-09 19:40 Ulrich Weigand
2007-12-16 22:04 ` Daniel Jacobowitz
2007-12-17 20:06 ` Jim Blandy [this message]
2008-01-14 15:55 ` Ulrich Weigand
2008-01-28 21:08 ` Ulrich Weigand
2008-01-28 23:48 ` Daniel Jacobowitz
2008-01-29 19:00 ` Ulrich Weigand
2008-01-29 3:42 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34pehje1b.fsf@codesourcery.com \
--to=jimb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox