Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: jimb@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: [rfc] Make DWARF-2 "address size" explicit
Date: Mon, 28 Jan 2008 23:48:00 -0000	[thread overview]
Message-ID: <20080128210757.GA19391@caradoc.them.org> (raw)
In-Reply-To: <200801282052.m0SKqW4K030059@d12av02.megacenter.de.ibm.com>

On Mon, Jan 28, 2008 at 09:52:32PM +0100, Ulrich Weigand wrote:
> When comparing all this with what GDB currently does, there is
> one obvious error: GDB does not take the FDE encoding into
> account *at all* when accessing the operand of DW_CFA_set_loc
> in the .eh_frame section.  It looks like this was already noticed
> by Dan some time ago, but the associated patch:
> 
> http://www.cygwin.com/ml/gdb-patches/2006-10/msg00063.html
> 
> apparently was never applied.  Dan, are you still planning on
> applying this patch?

If you could look over that patch and tell me if it looks right, I'll
apply it.  I had no way to test it with valid debug information.

> Apart from that, it would appear that the most logical size to
> use for target addresses in DWARF expression evaluation would
> be the target "void *" size for .eh_frame FDEs, and the value
> of the associated compilation unit's .debug_info address size
> header field value for .debug_frame FDEs (however, I'm not sure
> how to best determine that).

DJ Delorie ran into this same mess on the GCC list a few days ago and
Ian had the helpful suggestion to just avoid the bits that depend on
the ambiguous "address size".  If enough people do that, maybe it
won't matter what we pick... I think your choices sound correct.  It's
hard for .debug_info, though, as there is no direct correlation or
dependency between the sections.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-01-28 21:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-09 19:40 Ulrich Weigand
2007-12-16 22:04 ` Daniel Jacobowitz
2007-12-17 20:06   ` Jim Blandy
2008-01-14 15:55     ` Ulrich Weigand
2008-01-28 21:08       ` Ulrich Weigand
2008-01-28 23:48         ` Daniel Jacobowitz [this message]
2008-01-29 19:00           ` Ulrich Weigand
2008-01-29  3:42       ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080128210757.GA19391@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jimb@codesourcery.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox