From: Tom Tromey <tromey@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
Hui Zhu <teawater@gmail.com>,
Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA, 5 of 3] save/restore process record, part 5 (gcore change)
Date: Mon, 19 Oct 2009 16:18:00 -0000 [thread overview]
Message-ID: <m34opv9x2v.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4ADA9558.2010202@vmware.com> (Michael Snyder's message of "Sat, 17 Oct 2009 21:11:04 -0700")
>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
Michael> +/* create_gcore_bfd -- helper for gcore_command (exported). */
Michael> +bfd *
Michael> +create_gcore_bfd (char *filename)
That comment is not very descriptive.
Michael> +/* write_gcore_file -- helper for gcore_command (exported). */
Michael> +
Michael> +void
Michael> +write_gcore_file (bfd *obfd)
Likewise.
Michael> Index: gcore.h
Michael> ===================================================================
Michael> RCS file: gcore.h
Michael> diff -N gcore.h
The gdb internals document says that headers should have include guards.
Tom
next prev parent reply other threads:[~2009-10-19 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-18 4:17 Michael Snyder
2009-10-19 16:18 ` Tom Tromey [this message]
2009-10-19 20:12 ` Michael Snyder
2009-10-22 19:42 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34opv9x2v.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox