From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 479 invoked by alias); 19 Oct 2009 16:18:32 -0000 Received: (qmail 471 invoked by uid 22791); 19 Oct 2009 16:18:31 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Oct 2009 16:18:25 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9JGIJrW005917; Mon, 19 Oct 2009 12:18:19 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n9JGIIG6007301; Mon, 19 Oct 2009 12:18:18 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n9JGIHne019985; Mon, 19 Oct 2009 12:18:17 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 02A35378216; Mon, 19 Oct 2009 10:18:17 -0600 (MDT) From: Tom Tromey To: Michael Snyder Cc: "gdb-patches\@sourceware.org" , Hui Zhu , Eli Zaretskii Subject: Re: [RFA, 5 of 3] save/restore process record, part 5 (gcore change) References: <4ADA9558.2010202@vmware.com> Reply-To: tromey@redhat.com Date: Mon, 19 Oct 2009 16:18:00 -0000 In-Reply-To: <4ADA9558.2010202@vmware.com> (Michael Snyder's message of "Sat, 17 Oct 2009 21:11:04 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00429.txt.bz2 >>>>> "Michael" == Michael Snyder writes: Michael> +/* create_gcore_bfd -- helper for gcore_command (exported). */ Michael> +bfd * Michael> +create_gcore_bfd (char *filename) That comment is not very descriptive. Michael> +/* write_gcore_file -- helper for gcore_command (exported). */ Michael> + Michael> +void Michael> +write_gcore_file (bfd *obfd) Likewise. Michael> Index: gcore.h Michael> =================================================================== Michael> RCS file: gcore.h Michael> diff -N gcore.h The gdb internals document says that headers should have include guards. Tom