From: Tom Tromey <tromey@redhat.com>
To: Stan Shebs <stan@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Disconnected tracing
Date: Wed, 06 Jan 2010 19:45:00 -0000 [thread overview]
Message-ID: <m34omz3tlu.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4B441D89.6030902@codesourcery.com> (Stan Shebs's message of "Tue, 05 Jan 2010 21:20:09 -0800")
>>>>> "Stan" == Stan Shebs <stan@codesourcery.com> writes:
Stan> This next patch realizes a long-anticipated advantage of tracepoints,
Stan> namely that it should be possible to disconnect GDB from the target
Stan> but leave the trace experiment running, then reconnect later to see if
Stan> anything interesting turned up.
A couple little nits...
Stan> + extern void create_tracepoint_from_upload (int num, enum bptype type,
Stan> + ULONGEST addr);
Could this be in a header? And then the declaration in
remote_get_tracing_state removed?
Maybe this is another of those "will be fixed by the target vector"
oddities.
Stan> + extern void
Stan> + create_tracepoint_from_upload (int num, enum bptype type, ULONGEST addr)
Stan> + {
It is weird to have "extern" on a definition.
Tom
next prev parent reply other threads:[~2010-01-06 19:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 5:20 Stan Shebs
2010-01-06 18:46 ` Eli Zaretskii
2010-01-06 19:23 ` Stan Shebs
2010-01-06 19:45 ` Tom Tromey [this message]
2010-01-06 19:56 ` Stan Shebs
2010-01-06 20:13 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34omz3tlu.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=stan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox