From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17540 invoked by alias); 6 Jan 2010 19:45:47 -0000 Received: (qmail 17531 invoked by uid 22791); 6 Jan 2010 19:45:47 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jan 2010 19:45:42 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o06JjYrT015421 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Jan 2010 14:45:35 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o06JjYlu023955; Wed, 6 Jan 2010 14:45:34 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o06JjX8D023396; Wed, 6 Jan 2010 14:45:34 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 2A59037817D; Wed, 6 Jan 2010 12:45:33 -0700 (MST) From: Tom Tromey To: Stan Shebs Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Disconnected tracing References: <4B441D89.6030902@codesourcery.com> Reply-To: tromey@redhat.com Date: Wed, 06 Jan 2010 19:45:00 -0000 In-Reply-To: <4B441D89.6030902@codesourcery.com> (Stan Shebs's message of "Tue, 05 Jan 2010 21:20:09 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00122.txt.bz2 >>>>> "Stan" == Stan Shebs writes: Stan> This next patch realizes a long-anticipated advantage of tracepoints, Stan> namely that it should be possible to disconnect GDB from the target Stan> but leave the trace experiment running, then reconnect later to see if Stan> anything interesting turned up. A couple little nits... Stan> + extern void create_tracepoint_from_upload (int num, enum bptype type, Stan> + ULONGEST addr); Could this be in a header? And then the declaration in remote_get_tracing_state removed? Maybe this is another of those "will be fixed by the target vector" oddities. Stan> + extern void Stan> + create_tracepoint_from_upload (int num, enum bptype type, ULONGEST addr) Stan> + { It is weird to have "extern" on a definition. Tom