From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] Fix printing of wide characters (Ada and C)
Date: Fri, 14 Jan 2011 16:54:00 -0000 [thread overview]
Message-ID: <m34o9bqvgi.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1294960709-13047-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Thu, 13 Jan 2011 18:18:29 -0500")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> (b) The second problem was in c-valprint, where we were down-casting
Joel> the integer value of the character to type `unsigned char',
Joel> causing use to lose all but the lowest byte.
Ouch. I am really surprised we missed this for so long.
Joel> * ada-valprint. (ada_printchar): Use the correct type length
Joel> in call to ada_emit_char.
Joel> * c-valprint.c (c_val_print): Remove cast in call to LA_PRINT_CHAR.
Joel> Tested on x86_64-linux. Ok to commit?
It looks good to me. I think it should go on the 7.2 branch as well.
Tom
next prev parent reply other threads:[~2011-01-14 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 23:21 Joel Brobecker
2011-01-14 16:54 ` Tom Tromey [this message]
2011-01-14 19:53 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34o9bqvgi.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox