From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26465 invoked by alias); 14 Jan 2011 16:52:45 -0000 Received: (qmail 26454 invoked by uid 22791); 14 Jan 2011 16:52:44 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Jan 2011 16:52:40 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0EGqGT4004694 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 14 Jan 2011 11:52:16 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p0EGqFBL007888; Fri, 14 Jan 2011 11:52:15 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p0EGqEcu007293; Fri, 14 Jan 2011 11:52:15 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 34913379883; Fri, 14 Jan 2011 09:52:13 -0700 (MST) From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFA/commit] Fix printing of wide characters (Ada and C) References: <1294960709-13047-1-git-send-email-brobecker@adacore.com> Date: Fri, 14 Jan 2011 16:54:00 -0000 In-Reply-To: <1294960709-13047-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Thu, 13 Jan 2011 18:18:29 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00333.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> (b) The second problem was in c-valprint, where we were down-casting Joel> the integer value of the character to type `unsigned char', Joel> causing use to lose all but the lowest byte. Ouch. I am really surprised we missed this for so long. Joel> * ada-valprint. (ada_printchar): Use the correct type length Joel> in call to ada_emit_char. Joel> * c-valprint.c (c_val_print): Remove cast in call to LA_PRINT_CHAR. Joel> Tested on x86_64-linux. Ok to commit? It looks good to me. I think it should go on the 7.2 branch as well. Tom