From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Python pretty-printing [1/6]
Date: Tue, 07 Apr 2009 18:43:00 -0000 [thread overview]
Message-ID: <m33ack1f1w.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20090407182431.GA7535@adacore.com> (Joel Brobecker's message of "Tue\, 7 Apr 2009 11\:24\:31 -0700")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
>> +#ifdef PYTHONDIR
>> + PyModule_AddStringConstant (gdb_module, "pythondir", PYTHONDIR);
>> +#else
>> + if (gdb_datadir)
>> + PyModule_AddStringConstant (gdb_module, "datadir", gdb_datadir);
>> +#endif
Joel> Can we change that, for instance by assuming that we always have
Joel> PYTHONDIR, and that by default, configure will set to the datadir?
This code is gone from the latest revision of the patch.
We don't actually need the pythondir stuff until we have a library of
Python code installed with gdb, and this patch series doesn't add that.
But, yes, I think we can clean this up when the time comes.
Joel> I was going to comment on the ..._RELOCATABLE macro, but I see that
Joel> we're already using that idiom for at least the system gdbinit file.
Yeah. I cleaned all this up a bit in the latest patch as well. That
is, I unified almost all of the cut-and-pasted code.
Tom
prev parent reply other threads:[~2009-04-07 18:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-02 20:54 Tom Tromey
2009-04-03 14:23 ` Eli Zaretskii
2009-04-03 15:46 ` Tom Tromey
2009-04-03 17:13 ` Eli Zaretskii
2009-04-04 21:43 ` Thiago Jung Bauermann
2009-04-05 3:12 ` Eli Zaretskii
2009-04-03 18:29 ` Tom Tromey
2009-04-03 19:14 ` Daniel Jacobowitz
2009-04-03 20:39 ` Tom Tromey
2009-04-03 15:23 ` Daniel Jacobowitz
2009-04-03 23:58 ` Tom Tromey
2009-04-04 3:30 ` Daniel Jacobowitz
2009-04-04 16:16 ` Tom Tromey
2009-04-04 9:10 ` Eli Zaretskii
2009-04-06 17:45 ` Tom Tromey
2009-04-06 20:38 ` Eli Zaretskii
2009-04-07 18:52 ` Daniel Jacobowitz
2009-04-07 18:24 ` Joel Brobecker
2009-04-07 18:43 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m33ack1f1w.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox