From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10558 invoked by alias); 7 Apr 2009 18:43:11 -0000 Received: (qmail 10548 invoked by uid 22791); 7 Apr 2009 18:43:10 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Apr 2009 18:43:04 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n37IgMV3027544; Tue, 7 Apr 2009 14:42:22 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n37IgNsL009271; Tue, 7 Apr 2009 14:42:23 -0400 Received: from opsy.redhat.com (vpn-13-55.rdu.redhat.com [10.11.13.55]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n37IgL1N027291; Tue, 7 Apr 2009 14:42:21 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 25D0950830B; Tue, 7 Apr 2009 12:42:20 -0600 (MDT) To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: Python pretty-printing [1/6] References: <20090407182431.GA7535@adacore.com> From: Tom Tromey Reply-To: Tom Tromey Date: Tue, 07 Apr 2009 18:43:00 -0000 In-Reply-To: <20090407182431.GA7535@adacore.com> (Joel Brobecker's message of "Tue\, 7 Apr 2009 11\:24\:31 -0700") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-04/txt/msg00129.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: >> +#ifdef PYTHONDIR >> + PyModule_AddStringConstant (gdb_module, "pythondir", PYTHONDIR); >> +#else >> + if (gdb_datadir) >> + PyModule_AddStringConstant (gdb_module, "datadir", gdb_datadir); >> +#endif Joel> Can we change that, for instance by assuming that we always have Joel> PYTHONDIR, and that by default, configure will set to the datadir? This code is gone from the latest revision of the patch. We don't actually need the pythondir stuff until we have a library of Python code installed with gdb, and this patch series doesn't add that. But, yes, I think we can clean this up when the time comes. Joel> I was going to comment on the ..._RELOCATABLE macro, but I see that Joel> we're already using that idiom for at least the system gdbinit file. Yeah. I cleaned all this up a bit in the latest patch as well. That is, I unified almost all of the cut-and-pasted code. Tom