Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix i386 memory-by-register access on amd64
Date: Thu, 25 Jun 2009 16:33:00 -0000	[thread overview]
Message-ID: <m33a9ogtnc.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20090429202916.GA21831@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Wed\, 29 Apr 2009 22\:29\:16 +0200")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Resurrecting an oldish thread.

Jan> While not trying to judge what is right or wrong:

Jan> I believe gdb.x86_64 debugging gdb.i386 inferior should behave exactly as
Jan> gdb.i386 debugging gdb.i386 inferior.

This sounds reasonable to me.  If I'm debugging a 32-bit inferior, it
seems weird to see a 64-bit address.

Jan> As value_as_address is a long function with many `return'
Jan> commands.  But I do not have any strong opinion on it - would you
Jan> like to fill a variable and using a single exit path which would
Jan> cut the result width?

This sounds ok to me.  value_as_address is really long, true, but it
is mostly comments.  There are really only 3 returns.

Tom


  parent reply	other threads:[~2009-06-25 16:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-29 10:27 Jan Kratochvil
2009-04-29 19:05 ` Mark Kettenis
2009-04-29 20:29   ` Jan Kratochvil
2009-04-29 20:45     ` Jan Kratochvil
2009-06-25 16:33     ` Tom Tromey [this message]
2009-07-06  8:19       ` Jan Kratochvil
2009-07-07 16:24         ` Ulrich Weigand
2009-07-07 16:54           ` Daniel Jacobowitz
2009-07-07 18:00           ` Mark Kettenis
2009-07-07 18:22             ` Jan Kratochvil
2009-07-07 18:43               ` Mark Kettenis
2009-07-08 13:20           ` [patch] /* */ for target_thread_architecture [Re: [patch] Fix i386 memory-by-register access on amd64] Jan Kratochvil
2009-07-09 12:51             ` Ulrich Weigand
2009-07-09 16:36               ` Jan Kratochvil
2009-07-08 14:42         ` [patch] Fix i386 memory-by-register access on amd64 Jan Kratochvil
2009-07-13 18:10           ` Ulrich Weigand
2009-07-13 19:42             ` Mark Kettenis
2009-07-13 20:32             ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m33a9ogtnc.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox