From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix dangling displays in separate debug
Date: Wed, 07 Apr 2010 19:25:00 -0000 [thread overview]
Message-ID: <m339z7vzeh.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100403095558.GA22520@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sat, 3 Apr 2010 11:55:58 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> 2010-04-03 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> * printcmd.c (display_uses_solib_p): Check also
Jan> SEPARATE_DEBUG_OBJFILE.
Jan> - if (SYMBOL_SYMTAB (symbol)->objfile == solib->objfile)
Jan> + if (SYMBOL_SYMTAB (symbol)->objfile == solib->objfile
Jan> + || SYMBOL_SYMTAB (symbol)->objfile
Jan> + == solib->objfile->separate_debug_objfile)
An objfile can now have multiple separate debuginfo objfiles, linked
using separate_debug_objfile_link.
So, I think this test should actually be:
if (SYMBOL_SYMTAB (symbol)->objfile == solib->objfile
|| SYMBOL_SYMTAB (symbol)->objfile->separate_debug_objfile_backlink
== solib->objfile)
What do you think?
Tom
next prev parent reply other threads:[~2010-04-07 19:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-03 9:56 Jan Kratochvil
2010-04-07 19:25 ` Tom Tromey [this message]
2010-04-09 15:30 ` Jan Kratochvil
2010-04-09 15:34 ` Pedro Alves
2010-04-09 15:53 ` Jan Kratochvil
2010-04-09 16:48 ` Pedro Alves
2010-04-09 20:01 ` Jan Kratochvil
2010-04-11 1:27 ` Pedro Alves
2010-04-19 14:25 ` Jan Kratochvil
2010-04-20 11:05 ` Pedro Alves
2010-04-22 22:30 ` Jan Kratochvil
2010-04-22 22:52 ` Pedro Alves
2010-04-22 23:17 ` Jan Kratochvil
2010-04-09 17:17 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m339z7vzeh.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox