From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29963 invoked by alias); 7 Apr 2010 19:25:02 -0000 Received: (qmail 29904 invoked by uid 22791); 7 Apr 2010 19:25:02 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 07 Apr 2010 19:24:57 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o37JOtPU031814 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 7 Apr 2010 15:24:56 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o37JOt73007079; Wed, 7 Apr 2010 15:24:55 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o37JOskU026598; Wed, 7 Apr 2010 15:24:54 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 4E29D379851; Wed, 7 Apr 2010 13:24:54 -0600 (MDT) From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix dangling displays in separate debug References: <20100403095558.GA22520@host0.dyn.jankratochvil.net> Reply-To: tromey@redhat.com Date: Wed, 07 Apr 2010 19:25:00 -0000 In-Reply-To: <20100403095558.GA22520@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Sat, 3 Apr 2010 11:55:58 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00152.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> 2010-04-03 Jan Kratochvil Jan> * printcmd.c (display_uses_solib_p): Check also Jan> SEPARATE_DEBUG_OBJFILE. Jan> - if (SYMBOL_SYMTAB (symbol)->objfile == solib->objfile) Jan> + if (SYMBOL_SYMTAB (symbol)->objfile == solib->objfile Jan> + || SYMBOL_SYMTAB (symbol)->objfile Jan> + == solib->objfile->separate_debug_objfile) An objfile can now have multiple separate debuginfo objfiles, linked using separate_debug_objfile_link. So, I think this test should actually be: if (SYMBOL_SYMTAB (symbol)->objfile == solib->objfile || SYMBOL_SYMTAB (symbol)->objfile->separate_debug_objfile_backlink == solib->objfile) What do you think? Tom