Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [RFA-v3] dwarf2read.c: Avoid complaint for char array of unspecified size
Date: Tue, 01 Jun 2010 19:07:00 -0000	[thread overview]
Message-ID: <m339x67erz.fsf@fleche.redhat.com> (raw)
In-Reply-To: <000f01cafe4e$17eccea0$47c66be0$@muller@ics-cnrs.unistra.fr>	(Pierre Muller's message of "Fri, 28 May 2010 12:11:09 +0200")

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre>   OK, I tried to follow that route,
Pierre> the tricky part was that we don't really know which objfile type
Pierre> is the same size as an address, but the patch is a bit lengthy...

Yeah, I don't know this either.  Your approach seems reasonable.

Pierre>   At the same time, I discovered that DW_AT_count was not supported,
Pierre> (maybe no compiler uses that, but it can't hurt to add
Pierre> support for this).

Thanks for doing this.

Pierre> +      /* Test "long long int", "long int", and "int" objfile types,
Pierre> +	 and select the last one having a size above or equal to the
Pierre> +	 architecture address size.  */

I think you should test these in the reverse order: int, then long, then
long long.  This assures you will find the smallest type that matches.

This patch is ok with that change.

Tom


  reply	other threads:[~2010-06-01 19:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <38685.0063725889$1274473713@news.gmane.org>
2010-05-21 22:13 ` [RFA] " Tom Tromey
2010-05-21 23:55   ` Pierre Muller
2010-05-24 15:35     ` Tom Tromey
2010-05-26 15:21       ` [RFA-v2] " Pierre Muller
     [not found]       ` <34200.8848595016$1274864816@news.gmane.org>
2010-05-27 20:09         ` Tom Tromey
2010-05-28 10:17           ` [RFA-v3] " Pierre Muller
2010-06-01 19:07             ` Tom Tromey [this message]
2010-06-02  6:25               ` Pierre Muller
2010-06-02 19:35                 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m339x67erz.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox