From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
To: <tromey@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFA] dwarf2read.c: Avoid complaint for char array of unspecified size
Date: Fri, 21 May 2010 23:55:00 -0000 [thread overview]
Message-ID: <002201caf93d$e6ea8190$b4bf84b0$@muller@ics-cnrs.unistra.fr> (raw)
In-Reply-To: <m3pr0px76l.fsf@fleche.redhat.com>
> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé : Friday, May 21, 2010 11:43 PM
> À : Pierre Muller
> Cc : gdb-patches@sourceware.org
> Objet : Re: [RFA] dwarf2read.c: Avoid complaint for char array of
> unspecified size
>
> >>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
> writes:
>
> Pierre> This code:
> Pierre> external char gdbint [];
> Pierre> generated a DW_TAG_subrange_type with zero attributes
> Pierre> to describe the `[]' part.
> Pierre> (compiled with gcc (Debian 4.3.2-1.1) 4.3.2.).
>
> I think this kind of DIE is explicitly ok, according to DWARF.
> See the paragraph toward the end of section 5.11 that describes what to
> do when a DW_TAG_subrange_type has no basis type.
For dwarf2, in it on 5.10, page number 47 (49 of pdf file).
If I understand this correctly, without anything it should be
a subrange of type "singed integer" having the same size as an address
for that target machine. This is not exactly what is done in the Irix
code I modified...
But I still don't get the bounds that we should use:
lower bound is 0, or 1 for fortran (default value),
but should upper bound be equal to lower bound or lower bound -1?
> So, I think this complaint is incorrect. It would be better to simply
> remove it.
This would mean that we should fix the code inside read_subrange_type, no?
Do you think that this would be the correct approach?
Pierre
next prev parent reply other threads:[~2010-05-21 23:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <38685.0063725889$1274473713@news.gmane.org>
2010-05-21 22:13 ` Tom Tromey
2010-05-21 23:55 ` Pierre Muller [this message]
2010-05-24 15:35 ` Tom Tromey
2010-05-26 15:21 ` [RFA-v2] " Pierre Muller
[not found] ` <34200.8848595016$1274864816@news.gmane.org>
2010-05-27 20:09 ` Tom Tromey
2010-05-28 10:17 ` [RFA-v3] " Pierre Muller
2010-06-01 19:07 ` Tom Tromey
2010-06-02 6:25 ` Pierre Muller
2010-06-02 19:35 ` Tom Tromey
2010-05-21 20:35 [RFA] " Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002201caf93d$e6ea8190$b4bf84b0$@muller@ics-cnrs.unistra.fr' \
--to=pierre.muller@ics-cnrs.unistra.fr \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox