From: Tom Tromey <tromey@redhat.com>
To: Caroline Tice <cmtice@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Add patches from Chromium OS gdb
Date: Tue, 02 Aug 2011 14:26:00 -0000 [thread overview]
Message-ID: <m339hj51ph.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CABtf2+RGpyyscUNth__BL5Mr9J-TnJ+2R9CUgsvZcg57L9v1AQ@mail.gmail.com> (Caroline Tice's message of "Mon, 1 Aug 2011 16:13:11 -0700")
>>>>> "Caroline" == Caroline Tice <cmtice@google.com> writes:
Caroline> This patch combines two patches from the Chromium OS gdb. The first
Caroline> patch conditionally includes <wchar.h> in several readline files.
I think readline fixes should be sent upstream first. If the readline
maintainer agrees to them, then we can put them in our tree.
However, are they really needed? In the current tree, the readline
source files include rlmbutil.h, which includes wchar.h.
Caroline> this is because gdb/Makefile contains no explicit -I path to
Caroline> the toplevel, and --with-system-readline disables the implicit
Caroline> -I path
I tried a build using --with-system-readline, and it worked fine for me.
So I think something else must be going on.
Tom
prev parent reply other threads:[~2011-08-02 14:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 23:13 Caroline Tice
2011-08-02 14:26 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m339hj51ph.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=cmtice@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox