From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31247 invoked by alias); 2 Aug 2011 14:26:55 -0000 Received: (qmail 31231 invoked by uid 22791); 2 Aug 2011 14:26:54 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Aug 2011 14:26:37 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p72EQaEm014965 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 2 Aug 2011 10:26:36 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p72EQZgN032753; Tue, 2 Aug 2011 10:26:35 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p72EQYhh016388; Tue, 2 Aug 2011 10:26:34 -0400 From: Tom Tromey To: Caroline Tice Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Add patches from Chromium OS gdb References: Date: Tue, 02 Aug 2011 14:26:00 -0000 In-Reply-To: (Caroline Tice's message of "Mon, 1 Aug 2011 16:13:11 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00027.txt.bz2 >>>>> "Caroline" == Caroline Tice writes: Caroline> This patch combines two patches from the Chromium OS gdb. The first Caroline> patch conditionally includes in several readline files. I think readline fixes should be sent upstream first. If the readline maintainer agrees to them, then we can put them in our tree. However, are they really needed? In the current tree, the readline source files include rlmbutil.h, which includes wchar.h. Caroline> this is because gdb/Makefile contains no explicit -I path to Caroline> the toplevel, and --with-system-readline disables the implicit Caroline> -I path I tried a build using --with-system-readline, and it worked fine for me. So I think something else must be going on. Tom