Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Abhijit Halder <abhijit.k.halder@gmail.com>
Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [PR 9514] Fixing parse error for "pointer to a function pointer"
Date: Mon, 03 Oct 2011 16:46:00 -0000	[thread overview]
Message-ID: <m339fauipv.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CAOhZP9xuEcQ97hb_DXK_ri0iR6pj_PDvtoJqCMPXMVpRcN+ZSg@mail.gmail.com>	(Abhijit Halder's message of "Thu, 29 Sep 2011 16:55:21 +0530")

>>>>> "Abhijit" == Abhijit Halder <abhijit.k.halder@gmail.com> writes:

Abhijit> I am re-submitting the whole thing once again for ease of review.

This patch needs a patch to the testsuite as well.  Any simple parser
fix should come with a test, as it is easy to do.

Also, please look at my earlier patch for this bug.  I think it shows
some cases that your patch does not address:

    http://sourceware.org/ml/gdb-patches/2008-08/msg00539.html

Perhaps I ought to simply commit that patch.  I am not sure why I never
have.  What do you think?

Tom


  reply	other threads:[~2011-10-03 16:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-29 10:44 Abhijit Halder
2011-09-29 10:51 ` Abhijit Halder
2011-09-29 11:13   ` Pedro Alves
2011-09-29 11:49     ` Abhijit Halder
2011-10-03 16:46       ` Tom Tromey [this message]
2011-10-06 21:09         ` Keith Seitz
2011-10-17 11:16           ` Abhijit Halder
2011-10-18 20:14             ` Keith Seitz
2011-10-18 20:51               ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m339fauipv.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=abhijit.k.halder@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox