From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84022-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30805 invoked by alias); 3 Oct 2011 16:46:15 -0000
Received: (qmail 30797 invoked by uid 22791); 3 Oct 2011 16:46:14 -0000
X-SWARE-Spam-Status: No, hits=-7.2 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Oct 2011 16:45:56 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p93GjpWa019598	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 3 Oct 2011 12:45:51 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p93GjoSl013219;	Mon, 3 Oct 2011 12:45:50 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p93Gjmn8024554;	Mon, 3 Oct 2011 12:45:49 -0400
From: Tom Tromey <tromey@redhat.com>
To: Abhijit Halder <abhijit.k.halder@gmail.com>
Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [PR 9514] Fixing parse error for "pointer to a function pointer"
References: <CAOhZP9yYEXV_rFEGQHPACeeYxiqAwYw4XjfNeozu18OWLFu24A@mail.gmail.com>	<CAOhZP9yqbRXOd6rP2v1mpjszvRhycAOP9JwJXa+SQNz7tF5BRQ@mail.gmail.com>	<201109291210.01022.pedro@codesourcery.com>	<CAOhZP9xuEcQ97hb_DXK_ri0iR6pj_PDvtoJqCMPXMVpRcN+ZSg@mail.gmail.com>
Date: Mon, 03 Oct 2011 16:46:00 -0000
In-Reply-To: <CAOhZP9xuEcQ97hb_DXK_ri0iR6pj_PDvtoJqCMPXMVpRcN+ZSg@mail.gmail.com>	(Abhijit Halder's message of "Thu, 29 Sep 2011 16:55:21 +0530")
Message-ID: <m339fauipv.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-10/txt/msg00025.txt.bz2

>>>>> "Abhijit" == Abhijit Halder <abhijit.k.halder@gmail.com> writes:

Abhijit> I am re-submitting the whole thing once again for ease of review.

This patch needs a patch to the testsuite as well.  Any simple parser
fix should come with a test, as it is easy to do.

Also, please look at my earlier patch for this bug.  I think it shows
some cases that your patch does not address:

    http://sourceware.org/ml/gdb-patches/2008-08/msg00539.html

Perhaps I ought to simply commit that patch.  I am not sure why I never
have.  What do you think?

Tom