From: Phil Muldoon <pmuldoon@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org, pedro@codesourcery.com
Subject: Re: [python] [doc] PR 12930/12802 (clarify Breakpoint::stop doco)
Date: Fri, 07 Oct 2011 10:22:00 -0000 [thread overview]
Message-ID: <m339f585kd.fsf@redhat.com> (raw)
In-Reply-To: <83obxugeev.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 06 Oct 2011 20:31:36 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Phil Muldoon <pmuldoon@redhat.com>
>> CC: eli@gnu.org, pedro@codesourcery.com
>> Date: Thu, 06 Oct 2011 11:58:51 +0100
>>
>> This patch address the PRs 12930, and 12802 which both arise from
>> confusion regarding the scope of actions in the Breakpoint::stop
>> callback. I have added some documentation to clarify.
>
> Thanks.
>
>> +When @value{GDBN} executes each @code{stop} method, the inferior has
>> +been stopped, but the internal state accounting for that inferior is
>> +undetermined. As the return value from each @code{stop} method has the
>> +potential to instruct @value{GDBN} to restart the inferior, or keep it
>> +in a stopped state, this indeterminate state will remain until the
>> +execution scope of each @code{stop} method has been completed.
>
> Do we really need this part? I feel it doesn't explain anything that
> is instrumental for the rest of this paragraph, and it sounds
> mysterious enough to puzzle and confuse. How about dropping it and
> just leaving the rest (minus the "Therefore" part)?
Yeah that is fine, I was just trying to justify why one should not
tinker with these areas during that time. But that's something we
should have not have in the manual, in retrospect. Thanks for the
review, I will make the changes and check it in.
Cheers
Phil
next prev parent reply other threads:[~2011-10-07 10:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 10:59 Phil Muldoon
2011-10-06 13:40 ` Pedro Alves
2011-10-06 13:58 ` Phil Muldoon
2011-10-06 14:02 ` Pedro Alves
2011-10-06 18:32 ` Eli Zaretskii
2011-10-07 10:22 ` Phil Muldoon [this message]
2011-10-07 13:48 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m339f585kd.fsf@redhat.com \
--to=pmuldoon@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox