Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: pmuldoon@redhat.com
Cc: gdb-patches@sourceware.org, eli@gnu.org
Subject: Re: [python] [doc] PR 12930/12802 (clarify Breakpoint::stop doco)
Date: Thu, 06 Oct 2011 14:02:00 -0000	[thread overview]
Message-ID: <201110061501.44330.pedro@codesourcery.com> (raw)
In-Reply-To: <m3d3ea8bng.fsf@redhat.com>

On Thursday 06 October 2011 14:58:27, Phil Muldoon wrote:
> Pedro Alves <pedro@codesourcery.com> writes:
> 
> > On Thursday 06 October 2011 11:58:51, Phil Muldoon wrote:
> >> 
> >> This patch address the PRs 12930, and 12802 which both arise from
> >> confusion regarding the scope of actions in the Breakpoint::stop
> >> callback.  I have added some documentation to clarify.
> >> 
> >> Pedro, please excuse the gratuitous CC, but beyond Eli's normal review
> >> can you please fact-check the documentation to make sure I am not
> >> writing something about states that is incorrect.
> >
> > Thanks!  Looks good fact-wise.  I think infcalls will make sense to call here
> > (we do support them in the normal breakpoint condition), but that
> > supposedly doesn't leave the inferior's state unaltered, so we're good.
> >
> > I could be made possible to self delete a breakpoint in the callback,
> > but that's not the current state of affairs, it seems.
> 
> I'm not opposed to allowing the user to delete, but my view is that
> "stop" should make decisions, and not alter state.  OTOH, I'm not
> strongly moved other than personal preferences, so I can remove that
> line if need be.

Oh I didn't mean for you to remove it.  We can't do that currently,
so let's leave it in.  I was thinking that we do have internal
breakpoints that self-delete on some occasions, and it may be
useful to do the same from python --- e.g., local watchpoints going
out of scope, and the scope breakpoint.

-- 
Pedro Alves


  reply	other threads:[~2011-10-06 14:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-06 10:59 Phil Muldoon
2011-10-06 13:40 ` Pedro Alves
2011-10-06 13:58   ` Phil Muldoon
2011-10-06 14:02     ` Pedro Alves [this message]
2011-10-06 18:32 ` Eli Zaretskii
2011-10-07 10:22   ` Phil Muldoon
2011-10-07 13:48   ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110061501.44330.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=eli@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox