Re: [PATCH] Tracing notes and metadata

[Tom Tromey <tromey@redhat.com>]

>>>>> "Stan" == Stan Shebs <stan_shebs@mentor.com> writes:

Stan> This patch brings social networking to GDB! :-)

Your IPO awaits.

Stan> The patch still needs testsuite and NEWS, but considering the user
Stan> interface tinkering, it seemed like a good idea to solicit feedback
Stan> before committing to all the details.

I read through this.  The UI changes are fine by me.  I have a couple
nits about the patch, but that is all.

Stan>     int circular_buffer;
Stan> + 
Stan> +   char *user_name;
Stan> + 
Stan> +   char *notes;
Stan> + 
Stan> +   LONGEST start_time;
Stan> + 
Stan> +   LONGEST stop_time;
Stan>   };

I'd like comments on new fields.

It would be nice to add Usage lines now to the tstart and tstop help
text; the help text needs a little update anyhow to account for the new
feature.

Tom