From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14806 invoked by alias); 3 Nov 2011 15:18:23 -0000 Received: (qmail 14794 invoked by uid 22791); 3 Nov 2011 15:18:22 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Nov 2011 15:18:00 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA3FHvuT029237 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 3 Nov 2011 11:17:57 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA3FHvK8008398; Thu, 3 Nov 2011 11:17:57 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA3FHtUV002662; Thu, 3 Nov 2011 11:17:55 -0400 From: Tom Tromey To: Stan Shebs Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Tracing notes and metadata References: <4E9C5112.9070705@mentor.com> Date: Thu, 03 Nov 2011 15:18:00 -0000 In-Reply-To: <4E9C5112.9070705@mentor.com> (Stan Shebs's message of "Mon, 17 Oct 2011 09:00:18 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00071.txt.bz2 >>>>> "Stan" == Stan Shebs writes: Stan> This patch brings social networking to GDB! :-) Your IPO awaits. Stan> The patch still needs testsuite and NEWS, but considering the user Stan> interface tinkering, it seemed like a good idea to solicit feedback Stan> before committing to all the details. I read through this. The UI changes are fine by me. I have a couple nits about the patch, but that is all. Stan> int circular_buffer; Stan> + Stan> + char *user_name; Stan> + Stan> + char *notes; Stan> + Stan> + LONGEST start_time; Stan> + Stan> + LONGEST stop_time; Stan> }; I'd like comments on new fields. It would be nice to add Usage lines now to the tstart and tstop help text; the help text needs a little update anyhow to account for the new feature. Tom