Re: [PATCH 4/4 v20] Add xmethod support to the Python API

[Doug Evans <xdje42@gmail.com>]

Siva Chandra <sivachandra@google.com> writes:

> Doug> Well, almost all of them ...
>
> Sorry, I had sent an older version v19 in my local repo. The attached
> v20 should have all of them addressed.
>
> ChangeLog
> 2014-06-02  Siva Chandra Reddy  <sivachandra@google.com>
>
>         * python/py-xmethods.c: New file.
>         * python/py-objfile.c (objfile_object): New field 'xmethods'.
>         (objfpy_dealloc): XDECREF on the new xmethods field.
>         (objfpy_new, objfile_to_objfile_object): Initialize xmethods
>         field.
>         (objfpy_get_xmethods): New function.
>         (objfile_getset): New entry 'xmethods'.
>         * python/py-progspace.c (pspace_object): New field 'xmethods'.
>         (pspy_dealloc): XDECREF on the new xmethods field.
>         (pspy_new, pspace_to_pspace_object): Initialize xmethods
>         field.
>         (pspy_get_xmethods): New function.
>         (pspace_getset): New entry 'xmethods'.
>         * python/python-internal.h: Add declarations for new functions.
>         * python/python.c (_initialize_python): Invoke
>         gdbpy_initialize_xmethods.
>         * python/lib/gdb/__init__.py (xmethods): New
>         attribute.
>         * python/lib/gdb/xmethod.py: New file.
>         * python/lib/gdb/command/xmethods.py: New file.
>
>         testuite/
>         * gdb.python/py-xmethods.cc: New testcase to test xmethods.
>         * gdb.python/py-xmethods.exp: New tests to test xmethods.
>         * gdb.python/py-xmethods.py: Python script supporting the
>         new testcase and tests.

LGTM, thanks.