From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-112983-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 6510 invoked by alias); 3 Jun 2014 02:02:54 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 6026 invoked by uid 89); 3 Jun 2014 02:02:49 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-pa0-f42.google.com
Received: from mail-pa0-f42.google.com (HELO mail-pa0-f42.google.com) (209.85.220.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 03 Jun 2014 02:02:47 +0000
Received: by mail-pa0-f42.google.com with SMTP id bj1so1790777pad.1        for <gdb-patches@sourceware.org>; Mon, 02 Jun 2014 19:02:46 -0700 (PDT)
X-Received: by 10.66.175.166 with SMTP id cb6mr23109863pac.128.1401760966090;        Mon, 02 Jun 2014 19:02:46 -0700 (PDT)
Received: from seba.sebabeach.org.gmail.com (173-13-178-50-sfba.hfc.comcastbusiness.net. [173.13.178.50])        by mx.google.com with ESMTPSA id cj1sm71718583pac.40.2014.06.02.19.02.45        for <multiple recipients>        (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);        Mon, 02 Jun 2014 19:02:45 -0700 (PDT)
From: Doug Evans <xdje42@gmail.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 4/4 v20] Add xmethod support to the Python API
References: <CAGyQ6gy9LcaAJ-LSqrnwz+6HZDQ-ZX9wvRgWgu+rKFBTaNMmXA@mail.gmail.com>
Date: Tue, 03 Jun 2014 02:02:00 -0000
In-Reply-To: <CAGyQ6gy9LcaAJ-LSqrnwz+6HZDQ-ZX9wvRgWgu+rKFBTaNMmXA@mail.gmail.com>	(Siva Chandra's message of "Mon, 2 Jun 2014 11:58:44 -0700")
Message-ID: <m338fmeonf.fsf@sspiff.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-IsSubscribed: yes
X-SW-Source: 2014-06/txt/msg00055.txt.bz2

Siva Chandra <sivachandra@google.com> writes:

> Doug> Well, almost all of them ...
>
> Sorry, I had sent an older version v19 in my local repo. The attached
> v20 should have all of them addressed.
>
> ChangeLog
> 2014-06-02  Siva Chandra Reddy  <sivachandra@google.com>
>
>         * python/py-xmethods.c: New file.
>         * python/py-objfile.c (objfile_object): New field 'xmethods'.
>         (objfpy_dealloc): XDECREF on the new xmethods field.
>         (objfpy_new, objfile_to_objfile_object): Initialize xmethods
>         field.
>         (objfpy_get_xmethods): New function.
>         (objfile_getset): New entry 'xmethods'.
>         * python/py-progspace.c (pspace_object): New field 'xmethods'.
>         (pspy_dealloc): XDECREF on the new xmethods field.
>         (pspy_new, pspace_to_pspace_object): Initialize xmethods
>         field.
>         (pspy_get_xmethods): New function.
>         (pspace_getset): New entry 'xmethods'.
>         * python/python-internal.h: Add declarations for new functions.
>         * python/python.c (_initialize_python): Invoke
>         gdbpy_initialize_xmethods.
>         * python/lib/gdb/__init__.py (xmethods): New
>         attribute.
>         * python/lib/gdb/xmethod.py: New file.
>         * python/lib/gdb/command/xmethods.py: New file.
>
>         testuite/
>         * gdb.python/py-xmethods.cc: New testcase to test xmethods.
>         * gdb.python/py-xmethods.exp: New tests to test xmethods.
>         * gdb.python/py-xmethods.py: Python script supporting the
>         new testcase and tests.

LGTM, thanks.